-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add formio POC #84
Add formio POC #84
Conversation
paulfalgout
commented
Sep 18, 2019
- Add the Clubhouse Story ID: [ch21006]
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Something strange going on with istanbul and the handlebars update handlebars-lang/handlebars.js#1553 I'm going to revert that update shortly. I think the test are ok, but I need to test further. |
Codecov Report
@@ Coverage Diff @@
## develop #84 +/- ##
========================================
Coverage 97.62% 97.62%
========================================
Files 79 79
Lines 1434 1434
========================================
Hits 1400 1400
Misses 34 34 Continue to review full report at Codecov.
|
Going to rebuild the commits, but here's the form example: https://fe-feature-ch21006-formio-poc.preview.roundingwell.com/forms/12345 |
Updating dependencies reduces our overall installs, but our libs won't share dependencies.
If a redirectPath isn't in localStorage it's possible for login to try and route to `authenticate/`. This change ensures that the user is at least redirected somewhere valid.
4c7d2cb
to
2800b1b
Compare